Comments on: PHP Get File Extension

By: Peter

Peter — Wed, 28 Mar 2012 20:05:59 +0000

Mr Doe, happy to be of service. Don’t forget to clean up.

By: John doe

John doe — Wed, 28 Mar 2012 20:01:45 +0000

Wow a high level programming discussion, i came…

By: Peter

Peter — Mon, 19 Mar 2012 09:06:15 +0000

publo, pathinfo() is "secure" in the sense that it does exactly, and only, the job requested of it as documented. If you try to use pathinfo() in a manner other than it is supposed to be used, then it is the developer's failing. With regards to that article, the developer is simply demonstrating a completely incorrect method for validating the input: pathinfo() is still doing its job correctly. The function is not insecure, the developer trying to use it where it is not appropriate, is.

By: publo

publo — Mon, 19 Mar 2012 05:53:57 +0000

yo Peter

pathinfo() is not secure
http://www.madirish.net/?article=232

By: Eliud

Eliud — Sun, 11 Mar 2012 21:35:30 +0000

Hey, just here to drop a “Thank You!” for showing us this snippet of code. Very simple, but beats the way I was doing it by a mile (r by milliseconds, which is, a lot in terms of a script). Thank you!

By: Peter

Peter — Fri, 17 Feb 2012 18:45:33 +0000

Dan, yes pathinfo() will work with paths in $_FILES. It just takes a string containing a file path and doesn't care a jot where it came from.

By: dan

dan — Fri, 17 Feb 2012 17:00:51 +0000

Hi,

does the pathinfo() method work with files in the $_FILES array in http post/get?

being unsure, i’m using the explode way for now.

thanks for this post, it’s cool.

By: Peter

Peter — Sat, 04 Feb 2012 12:58:26 +0000

Jacob, this is because pathinfo() works on filesystem paths not URLs. For your example with a URL, you could get the path by using parse_url().

$path = parse_url($url, PHP_URL_PATH);

$ext  = pathinfo($path, PATHINFO_EXTENSION);

By: Jakob Sternberg

Jakob Sternberg — Sat, 04 Feb 2012 02:57:52 +0000

The only thing that fails is if the path has a query line attached. Like

echo pathinfo("http://mysite.com/page.php?file=msg.txt", PATHINFO_EXTENSION)

- it will output ‘txt’

Just a note. easy to fix offcourse:

function getFileExtension($p) {

   if( strpos($p,"?") != '' ) $p = substr($p, 0, strpos($p,"?") ); 

   return pathinfo($p, PATHINFO_EXTENSION);

   }

echo getFileExtension("http://mysite.com/page.php?file=msg.txt")

- will output ‘php’

Thanks for the heads up on PATHINFO_EXTENSION!

By: Ram Kishor Agrawal

Ram Kishor Agrawal — Wed, 01 Feb 2012 06:52:58 +0000

Beautifully explained. Thanks!